Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw the error #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Throw the error #44

wants to merge 1 commit into from

Conversation

jridgewell
Copy link

There's no need to return a Rejected Promise inside a #then block.

@jridgewell
Throw the error
a81d2a6 
There's no need to return a Rejected Promise inside a `#then` block.
@rkatic
Copy link

rkatic commented Sep 26, 2016

Unfortunately this will not work with jQuery 2 promises, since it is not supporting throwing.

@everdimension
Copy link

@rkatic Can you please give an example of a scenario where Promise.reject will work correctly for jquery and throw will not?...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jridgewell @rkatic @everdimension