Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "DisplayName" on ReactReduxContext for DevTools #1461

Closed
pieplu opened this issue Nov 13, 2019 · 1 comment
Closed

Add a "DisplayName" on ReactReduxContext for DevTools #1461

pieplu opened this issue Nov 13, 2019 · 1 comment

Comments

@pieplu
Copy link
Contributor

pieplu commented Nov 13, 2019

What is the current behavior?

ReactReduxContext don't have a DisplayName. It will be usefull on devtools.

Actually it's look's like:

image

What is the expected behavior?

Insted of "Context.Provider" in devTools, I expect see "ReactRedux.Provider" or "ReactReduxContext.Provider"

React: 16.8
React-redux: 7.1

I will propose a PR
pieplu added a commit to pieplu/react-redux that referenced this issue Nov 13, 2019
@pieplu
reduxjs#1461 Add a displayName on ReactReduxContext
fb0d06f
@pieplu pieplu mentioned this issue Nov 13, 2019
Merged
@timdorr
Copy link
Member

timdorr commented Nov 13, 2019

Thanks, but I don't think we need this.

@timdorr timdorr closed this as completed Nov 13, 2019
pieplu added a commit to pieplu/react-redux that referenced this issue Nov 13, 2019
@pieplu
lint, remove semicolon reduxjs#1461
0762f49
timdorr pushed a commit that referenced this issue Nov 13, 2019
@pieplu @timdorr
#1461 Add a displayName on ReactReduxContext (#1462)
a84eec9 
* #1461 Add a displayName on ReactReduxContext

* lint, remove semicolon #1461
@TejasQ TejasQ mentioned this issue Nov 25, 2019
Closed
albertodev7 pushed a commit to albertodev7/react-redux that referenced this issue Dec 8, 2022
@pieplu @timdorr
reduxjs#1461 Add a displayName on ReactReduxContext (reduxjs#1462)
3a6c48d 
* reduxjs#1461 Add a displayName on ReactReduxContext

* lint, remove semicolon reduxjs#1461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timdorr @pieplu