Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux style guide not discoverable from React Redux docs #1495

Closed
devanfarrell opened this issue Jan 8, 2020 · 2 comments
Closed

Redux style guide not discoverable from React Redux docs #1495

devanfarrell opened this issue Jan 8, 2020 · 2 comments
Labels

Comments

@devanfarrell
Copy link

Related to #1001

Potential solutions:

  • Link to guide in the list of guides in the side navigation pane
  • Duplicate the content of the style guide to both documentation sites
  • Migrate the react-redux specific guide only
@timdorr timdorr changed the title react-redux style guide not discoverable from react-redux docs Redux style guide not discoverable from React Redux docs Jan 8, 2020
@timdorr
Copy link
Member

timdorr commented Jan 8, 2020

I assume you meant the Redux style guide, as we don't have one specific to React Redux (yet).

I think migrating over the React-specific stuff is probably the correct approach. Redux still needs to maintain a framework-agnostic stance in its docs, IMHO.

@markerikson
Copy link
Contributor

But at the same time, the Redux core docs completely assume you're using React in a lot of places (tutorials, etc).

I'd be okay with mirroring the info, or pointing to it, but I'd kinda like to keep the whole page there as-is.

@timdorr timdorr added the docs label Jan 31, 2020
luispena28 added a commit to luispena28/react-redux that referenced this issue Jun 9, 2021
timdorr pushed a commit that referenced this issue Jun 10, 2021
toptaldev92 pushed a commit to toptaldev92/react-redux that referenced this issue Jul 28, 2021
kronooss added a commit to kronooss/coin-trading that referenced this issue Aug 22, 2022
sven971105 added a commit to sven971105/react-redux that referenced this issue Sep 21, 2022
charmingdev222 pushed a commit to charmingdev222/react-redux-demo that referenced this issue May 16, 2023
ZinedineDumas pushed a commit to harry908nilson/edux that referenced this issue Aug 4, 2023
MiyamotoSatoshi added a commit to MiyamotoSatoshi/redux that referenced this issue Aug 15, 2023
peace19920726 added a commit to peace19920726/React-Redux-Dev that referenced this issue Sep 1, 2023
Bee1130 added a commit to Bee1130/React-Redux that referenced this issue Jan 19, 2024
fairsky0201 added a commit to fairsky0201/react-redux that referenced this issue Apr 17, 2024
pumatopdev added a commit to pumatopdev/react-redux that referenced this issue Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants