remove react-is/isValidElementType from production builds #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 07ffa73 |
alexreardon
changed the title
|
Seems potentially reasonable. @timdorr , thoughts? |
|
Given this is a setup issue, I think a development check is appropriate |
|
Yep, seems like a good idea to me. |
|
🎉
…On Fri, 2 Nov 2018 at 1:16 am, Tim Dorr ***@***.***> wrote:
Yep, seems like a good idea to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1069 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFN7amkZU_m-iiY-KPzM7QnYXY3qb1vks5uqwJZgaJpZM4YFizW>
.
|
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to only run the code for checking whether an element is valid in non-production builds.
By implementing this change, bundlers can tree shake out
react-isaltogether for production builds 👍I think this is fine to be a development only check