Fix add missing peer dependency #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-dom is used in production code, so it should be a peer dependency https://github.com/reduxjs/react-redux/blob/fa5857281a37545c7c036fb2499159b865b1c57d/src/utils/reactBatchedUpdates.js#L2 It currently causes issues with pnpm which won't provide access to packages that are not declared as dependencies in package.json
|
Deploy preview for react-redux-docs ready! Built with commit cdaf2eb |
|
No, it shouldn't be, because of how we're handling the imports. Please see #1366 for prior discussion. |
This was referenced Oct 14, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-dom is used in production code, so it should be a peer dependency
react-redux/src/utils/reactBatchedUpdates.js
Line 2 in fa58572
It currently causes issues with pnpm which won't provide access to packages that
are not declared as dependencies in package.json