Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused latestStoreState field #1426

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Conversation

Hypnosphi
Copy link
Contributor

@Hypnosphi Hypnosphi commented Oct 14, 2019

  1. This field doesn't actually affect anything: action.payload is always a fresh object anyway
  2. Holding a reference to some arbitrary state from the past (namely, the one that triggered the last update for given component) leads to huge memory leaks if the state object is large and there are lots of connected components.

1. This field doesn't actually affect anything: `action.payload` is always a fresh object anyway
2. Having reference to some arbitrary state from the past (namely, the one that triggered the last update for given component) leads to huge memory leaks if the state object is large and there are lots of connected components.
@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for react-redux-docs ready!

Built with commit ae4bfb4

https://deploy-preview-1426--react-redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Oct 14, 2019

Thanks!

@timdorr timdorr merged commit 6725400 into reduxjs:master Oct 14, 2019
albertodev7 pushed a commit to albertodev7/react-redux that referenced this pull request Dec 8, 2022
* Remove unused `latestStoreState` field

1. This field doesn't actually affect anything: `action.payload` is always a fresh object anyway
2. Having reference to some arbitrary state from the past (namely, the one that triggered the last update for given component) leads to huge memory leaks if the state object is large and there are lots of connected components.

* Revert redundant change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants