fix performance createListenerCollection #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-redux-docs ready! Built with commit 58a4b27 |
|
Can you provide some numbers on how this performs better? |
I added screenshots to make it clear. |
|
OK, I cleaned things up a bit. We used the previous current/next form copied from Redux core because we wanted to ensure adding a subscriber while dispatching wouldn't trigger an edge case. However, since this code is nested inside of Subscription anyways, we actually don't need these guarantees. Thanks for the PR! |
|
I'm sorry, I made a mistake. This PR must be revert. Because it led to the wrong order of calling parent/child selectors.😟 |
leshkovichpvl
added a commit
to leshkovichpvl/react-redux
that referenced
this pull request
Nov 7, 2019
This reverts commit 476c0de.
timdorr
pushed a commit
that referenced
this pull request
Nov 7, 2019
1 task
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
* fix performance createListenerCollection * fix get for test * small fix * Simplify, pretty up, and remove vars
albertodev7
pushed a commit
to albertodev7/react-redux
that referenced
this pull request
Dec 8, 2022
…uxjs#1452) This reverts commit 476c0de.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createListenerCollection has a bad performance for more listeners.
In my implementation, performance is much better
before:
after:
