-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import bindActionCreators from redux #1705
Conversation
This is backwards compatible with npm@6
Size Change: +104 B (0%) Total Size: 26.6 kB
|
Deploy preview for react-redux-docs ready! Built with commit d83be43 |
BTW, I got rid of the type guards, since we're already doing that before calling this function. I also removed the function-to-function option, since I don't think that's a valid code path we use anywhere. |
Hah, was just about to ask about those two changes :) Yeah, if we're already confident we've got the right shape, that should be fine. |
(uh... side question: why does |
Oh, did you bump NPM from v6 to v7? I've still been using v6 locally for everything. I guess at some point I may have to bite the bullet and upgrade that on my machine. |
Yeah, I upgraded locally. It's backwards compatible with npm@6, so it shouldn't be a problem. If it starts flapping back and forth, I can revert back until the tooling catches up. |
I was just about to raise an issue about this, so glad I found out this was done 👍 is there an ETA on a new release with this change? |
Tentatively in the next few days? Juggling a lot of things atm, but I'll see if I can get around to cutting 7.2.4. |
Closes #1498
This removes our peer dep on Redux itself. Technically, anything that implements the Redux API/behaviors should work A-OK with React Redux.
This also makes it easy to work with different version of Redux, if we eventually get to releasing 5.0. Less scary warnings from npm/yarn.