Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert package management to Yarn v2 #1751

Merged
merged 8 commits into from
Jul 3, 2021
Merged

Conversation

markerikson
Copy link
Contributor

This PR:

  • Switches the React-Redux package management process to use Yarn v2
    • Added Yarn "binary" and config file, and added a lockfile
    • Updated gitignore
    • Marked the website folder as a workspace
    • Switched the build steps to use Yarn
    • Removed the NPM lockfiles

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

Size Change: 0 B

Total Size: 20.3 kB

ℹ️ View Unchanged
Filename Size Change
dist/react-redux.js 15.3 kB 0 B
dist/react-redux.min.js 5.02 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jul 3, 2021

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: 74d7043

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60e0d2dd38f37c0008bbc9c3

😎 Browse the preview: https://deploy-preview-1751--react-redux-docs.netlify.app

@markerikson markerikson merged commit 5a11915 into typescript-port Jul 3, 2021
@markerikson markerikson deleted the feature/yarn-v2 branch July 3, 2021 21:17
@timdorr
Copy link
Member

timdorr commented Jul 4, 2021

I'm not familiar, but why does .yarn/releases/yarn-berry.cjs exist? That looks to be yarn itself, which I would assume to be redundant to your own local version.

@markerikson
Copy link
Contributor Author

This is actually how Yarn v2 is designed to work: installations are per-project, and the Yarn "binary" is supposed to be committed to the repo.

Yarn v1 has to be installed globally, and then you have a config file in the repo that says "use v2". When you run yarn in the repo folder, v1 starts, looks at the config file, sees "v2", and bootstraps the execution of v2 from there.

It's admittedly kinda goofy, but it works.

Comment on lines +6 to +7
- path: .yarn/plugins/@yarnpkg/plugin-compat.cjs
spec: '@yarnpkg/plugin-compat'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be needed if we're using node-modules above. The PNP linker is disabled, so this package shouldn't have any effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants