Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: modify jest config, ts-jest => 26.xx.xx, tsconfig'include add … #1770

Merged
merged 7 commits into from
Jul 19, 2021
Merged

chore: modify jest config, ts-jest => 26.xx.xx, tsconfig'include add … #1770

merged 7 commits into from
Jul 19, 2021

Conversation

myNameIsDu
Copy link
Contributor

I found some big problems:

  • ts-jest does not check the converted type file, the previous configuration was problematic

  • I have now fixed it, but due to the strict mode of tsconfig, there are some type errors that need to be reworked 😭

ref: #1737

@netlify
Copy link

netlify bot commented Jul 16, 2021 •
edited
Loading

✔️ Deploy Preview for react-redux-docs ready!

🔨 Explore the source changes: 79cbb10

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/60f5705fda239e00079fe719

😎 Browse the preview: https://deploy-preview-1770--react-redux-docs.netlify.app

timdorr
timdorr reviewed Jul 16, 2021
View reviewed changes
package.json
@@ -109,7 +109,7 @@
"rimraf": "^3.0.2",
"rollup": "^2.32.1",
"rollup-plugin-terser": "^7.0.2",
"ts-jest": "^27.0.3",
"ts-jest": "26.5.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being downgraded?

Copy link
Contributor Author

@myNameIsDu myNameIsDu Jul 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was using ts-jest@27, I encountered some problems
Then I upgraded jest to version 27 and encountered this problem again
In the end, I can only use version 26 first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition,I will fix the problem left over from converting the TS file, But this may take some time, as strict type checking may require a lot of additional fixes:cold_sweat:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 19, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 79cbb10:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@myNameIsDu myNameIsDu requested a review from timdorr July 19, 2021 12:33
@markerikson
Copy link
Contributor

Tests are passing, changes look good. Anything else you want to do in this PR, or is it good to merge?

@myNameIsDu
Copy link
Contributor Author

Tests are passing, changes look good. Anything else you want to do in this PR, or is it good to merge?

I think it is OK to merge, and I will initiate PR in future updates

@markerikson
Copy link
Contributor

Great, thanks again!

@markerikson markerikson merged commit 1f4d970 into reduxjs:typescript-port Jul 19, 2021
@myNameIsDu myNameIsDu deleted the refactor/test-components-provider branch July 20, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdorr timdorr Awaiting requested review from timdorr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myNameIsDu @markerikson @timdorr