Add a "compat" entry point that works with React 16.9+ and 17 #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the same trick we do with batchedUpdates: a module with variables + getter/setter functions. Each entry point is then responsible for importing the right variables and setting them. This happens before the modules are loaded, so we can then import the getters where they're needed and call them to get the right instances of `useSyncExternalStore`. The "compat" and "alternate-renderer" entry points both use the `uSES` shim, so they should be compatible back to React 16.9+. The primary entry point imports directly from React, and thus assumes React 18.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87d1ec4:
|
|
✔️ Deploy Preview for react-redux-docs ready! 🔨 Explore the source changes: 87d1ec4 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-redux-docs/deploys/619725af6087f1000887c035 😎 Browse the preview: https://deploy-preview-1842--react-redux-docs.netlify.app |
|
Size Change: +1.57 kB (7%) 🔍 Total Size: 21.2 kB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
useSyncExternalStoreshim, enabling compatibility with React 16.9+ and 17 if used instead of the default entry pointloose-envifydependency and thebrowserifykey frompackage.json. If you're still using Browserify and this is somehow needed, please configure your own build setup to transpile this package accordingly.