connectComponent, attaching prop configuration to component #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgriesser
force-pushed
the
connectFactory
branch
from
5770eaa to
25f97c7
Compare
tgriesser
referenced
this pull request
in tgriesser/react-redux
Nov 11, 2015
* master: rename smart/dumb to presentational/container Add jsnext:main Remove src from npmignore
tgriesser
changed the title
|
What if instead we checked the return type of |
|
Oh, good shout. I don't think you are missing anything. I just hacked together a quick test for mapStateToProps, and it seems like it would be a reasonable solution. |
|
@tgriesser Would you be interested in implementing #185 (comment) as an alternative approach? Would it solve your problem? |
|
I’ll close this PR because I don’t plan to merge it as is but I’m happy to consider merging #185 (comment) which should solve the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #179 for consideration, adds a
connectFactoryconnectComponentwhichconnectwill wrap, allowing for unique selectors per-component instance. Existing use of connect will work the same as it does currently.