Support passing store in via props for testing #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,7 @@ export default function createConnect(React) { | |||
| static WrappedComponent = WrappedComponent; | |||
|
|
|||
| static contextTypes = { | |||
| store: storeShape.isRequired | |||
| store: storeShape | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Let's add similar propTypes then?
| this.dispatchProps = computeDispatchProps(context); | ||
| this.store = props.store || context.store; | ||
|
|
||
| invariant(this.store, '`store` must be passed in via the context or props'); |
There was a problem hiding this comment.
Let's change it to
Could not find "store" in either context or props of "${this.constructor.displayName}". Either wrap the root component in a , or explicitly pass "store" as a prop to "${this.constructor.displayName}".
and also verify that the error message is correct in a unit test.
There was a problem hiding this comment.
updated with test.
|
Thank you for your work on this. Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow you to pass the redux store in via props to make it easier to unit test (Instead of having to mess with
Provider's or contexts)See also #38
Closes #33