Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test #51

Merged
merged 3 commits into from
Aug 11, 2015
Merged

Add failing test #51

merged 3 commits into from
Aug 11, 2015

Conversation

istarkov
Copy link
Contributor

8.1 failing test
prehistory here

Test in first commit is new.

Changes in second commit is about that such keys also need to be deleted from this.state

@istarkov
Copy link
Contributor Author

2 fix first failing test, it's need to change

const resetValue = (_, key) => ({[key]: undefined });

on this

const resetValue = (r, key) => ({ ...r, [key]: undefined });

@istarkov
Copy link
Contributor Author

Third commit fixes both tests,
to emulate replaceState i've moved current state to state.props

not defined props must be removed instead of setting them undefined
gaearon added a commit that referenced this pull request Aug 11, 2015
@gaearon gaearon merged commit 83756ec into reduxjs:master Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants