Add TypeScript typings corresponding to redux@next #812
Conversation
index.d.ts
Outdated
| /** | ||
| * The single Redux store in your application. | ||
| */ | ||
| store?: Store<any, any>; |
There was a problem hiding this comment.
This is the main change from what's on DefinitelyTyped, which requires the new redux typings. Without it, users will probably run into problems instantiating Provider elements in the presence of TypeScript 2.6's --strictFunctionTypes.
|
This is not ready to merge until it can depend on the yet-to-be-released Redux 4 which will have the new typings. |
|
Thanks, @pelotom! Can any TS experts weigh in on this? |
index.d.ts
Outdated
| type Omit<T, K extends keyof T> = Pick<T, Diff<keyof T, K>>; | ||
|
|
||
| export interface DispatchProp<S> { | ||
| dispatch?: Dispatch<S>; |
There was a problem hiding this comment.
Isn't the Dispatch type parameter an action type now?
|
Looks good to me. Tests are missing though. |
|
Ah yes. @pelotom Can you pull in |
index.d.ts
Outdated
| export interface DispatchProp<S> { | ||
| dispatch?: Dispatch<S>; | ||
| export interface DispatchProp { | ||
| dispatch?: Dispatch<{}>; |
There was a problem hiding this comment.
No need to have a type parameter at all here since we were only instantiating it with any. Hard-coding it to {} instead of any because it's in a contravariant position.
|
Actually it looks like these definitions are compatible with both the current and |
|
Hm, I just saw #541, and I'm not sure about the relative merits of those typings vs these. The test cases are undoubtedly more comprehensive there. Is there any reason it seems to have been abandoned? Just no one got around to resolving merge conflicts? |
|
Closing this for now as I think #541 is a better foundation to build the |
Add built-in TypeScript typings copied from DefinitelyTyped but modified to accommodate upcoming revamped
reduxtypings on thenextbranch (see redux #2563).