feature(redux-devtools-inspector-monitor): sorted state tree #1264
Conversation
🦋 Changeset detectedLatest commit: 5d46901 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kentkwee
force-pushed
the
main
branch
3 times, most recently
from
edecfb1 to
3f55afa
Compare
| useEffect(() => { | ||
| if (!chrome || !chrome.storage) return; | ||
| const storage = isFF | ||
| ? chrome.storage.local | ||
| : chrome.storage.sync || chrome.storage.local; | ||
| storage.get( | ||
| ['sortStateTreeAlphabetically', 'disableStateTreeCollection'], | ||
| function (result) { | ||
| setSortObjectKeys(!!result.sortStateTreeAlphabetically); | ||
| setDisableCollection(!!result.disableStateTreeCollection); | ||
| } | ||
| ); | ||
| }, []); |
There was a problem hiding this comment.
Can we make it so these are props instead? Only the extension itself should be reading/writing settings from storage. It should then pass those settings down as props to the monitor.
There was a problem hiding this comment.
Sure. Will adjust it in the following days.
| invertTheme={invertTheme} | ||
| hideRoot | ||
| sortObjectKeys={sortObjectKeys} | ||
| {...(disableCollection ? { collectionLimit: 0 } : {})} |
There was a problem hiding this comment.
Can you explain what the use case for this option is?
There was a problem hiding this comment.
If the state does have a lot of keys they are collapsed. This option prevents this.
collectionLimit: number- sets the number of nodes that will be rendered in a collection before rendering them in collapsed ranges
|
I implemented the changes and replaced the options page. The settings are managed in the state now. |
kentkwee
force-pushed
the
main
branch
2 times, most recently
from
dad8f9b to
a7c68c0
Compare
|
I have rebased the pull request. |
…ree alphabetically and/or disable collections
|
@Methuselah96 Could you have a look again and tell me what's missing to get this merged? |
This pull request adds the options to sort the state tree alphabetically, and the option to prevent collecting object keys together.
Partially solves #433