Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace stack #418

Merged
merged 41 commits into from
Dec 18, 2018
Merged

Trace stack #418

merged 41 commits into from
Dec 18, 2018

Conversation

zalmoxisus
Copy link
Collaborator

@zalmoxisus zalmoxisus commented Dec 13, 2018

  • Create redux-devtools-trace-monitor from Show stack traces zalmoxisus/remotedev-app#43 as a separate package
  • Fix linting, dependences, transpiling and add tests
  • Ability to get stack trace using an outside function, to use something else then new Error.stack for providing stack traces, also for some use cases (when using setTimeout, setInterval, events...) stack traces are broken, so it can be composed outside.
  • Limit stack trace frames. There could appear a problem with consumed memory and serializing large stacks. For Chrome call stack is limited by default to 10. It doesn't include 3 our calls, which we're filtering with Error.captureStackTrace, so it should be enough. That can be changed with Error.stackTraceLimit = limit (some libraries could do that and cause issues). For Firefox the limit is hardcoded to 128 stack frames and it's unlimited in Safari. So we need to limit it.
  • Exclude instrumentation calls frames.
  • Rewrite styles to use redux-devtools-themes.
  • Open in editor when configured, also useful for Firefox, when used not from devpanel or for remote debugging.

We need here to show frames even if all came from node_modules
We need here to show frames even if all came from node_modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant