Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation addressed in #71 #123

Merged
merged 4 commits into from
Feb 1, 2018
Merged

Conversation

ohtangza
Copy link
Contributor

@ohtangza ohtangza commented Dec 25, 2017

Summary

Hello, as discussed in #71. I updated our documentation a bit with the aim of clarifying the purpose of this library. Hope this pull request helps new developer here get on their track without being confused.

Sponsor issue

@arnaudbenard Please update the sponsor section which is now broken. I was trying to fix it, but it seems that https://app.codesponsor.io is not accessible (perhaps, it is temporary). Please refer the screenshot below.

screen shot 2017-12-25 at 4 03 53 pm

Merry Christmas!!!

@dmitry-zaets
Copy link
Collaborator

Thanks a lot for the PR.
Looks good to me.

@arnaudbenard if it looks good to you - please merge.

@ohtangza
Copy link
Contributor Author

@arnaudbenard I resolved the merge conflict which occurred after my last commit.

@arnaudbenard
Copy link
Contributor

You can delete code sponsor, it's not available anymore.

@ohtangza
Copy link
Contributor Author

@arnaudbenard Sponsor removed!

@vekerdyb
Copy link

vekerdyb commented Feb 1, 2018

It would be lovely if this could be merged, it would have saved some time for me this morning! :)

@ohtangza
Copy link
Contributor Author

ohtangza commented Feb 1, 2018

@vekerdyb I also witnessed that some of my colleagues has been troubled with this as well. Glad to hear that :)

@arnaudbenard arnaudbenard merged commit eedcd9f into reduxjs:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants