Fixed Stackoverflow bug if children prop is a ref to root/parent object

reduxjs · May 8, 2023 · 58476a0 · 58476a0
1 parent 1e5c7a0
commit 58476a0
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/toolkit/src/immutableStateInvariantMiddleware.ts b/packages/toolkit/src/immutableStateInvariantMiddleware.ts
@@ -92,11 +92,13 @@ function trackProperties(
  isImmutable: IsImmutableFunc,
  ignorePaths: IgnorePaths = [],
  obj: Record<string, any>,
- path: string = ''
+ path: string = '',
+ checkedObjects: Set<Record<string, any>> = new Set()
 ) {
  const tracked: Partial<TrackedProperty> = { value: obj }
 
- if (!isImmutable(obj)) {
+ if (!isImmutable(obj) && !checkedObjects.has(obj)) {
+ checkedObjects.add(obj);
  tracked.children = {}
 
  for (const key in obj) {