Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust isLoading/isFetching explanation #1340

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

phryneas
Copy link
Member

Triggered by #1339

@Shrugsy can you give this a read-over if I'm making sense?

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 14f758a

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/60f9e6b1a4e75c00074511ed

😎 Browse the preview: https://deploy-preview-1340--redux-starter-kit-docs.netlify.app

@github-actions
Copy link

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit (cjs.production.min.js) 12.21 KB (0%)
1. entry point: @reduxjs/toolkit (esm.js) 10.21 KB (0%)
1. entry point: @reduxjs/toolkit/query (cjs.production.min.js) 20.31 KB (0%)
1. entry point: @reduxjs/toolkit/query (esm.js) 17.35 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (cjs.production.min.js) 22.18 KB (0%)
1. entry point: @reduxjs/toolkit/query/react (esm.js) 19.79 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs.production.min.js) 5.55 KB (0%)
2. entry point: @reduxjs/toolkit (without dependencies) (esm.js) 5.53 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs.production.min.js) 9.19 KB (0%)
2. entry point: @reduxjs/toolkit/query (without dependencies) (esm.js) 9.56 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (cjs.production.min.js) 2.36 KB (0%)
2. entry point: @reduxjs/toolkit/query/react (without dependencies) (esm.js) 2.21 KB (0%)
3. createSlice (esm.js) 5.15 KB (0%)
3. createEntityAdapter (esm.js) 5.82 KB (0%)
3. configureStore (esm.js) 5.83 KB (0%)
3. createApi (esm.js) 15.64 KB (0%)
3. createApi (react) (esm.js) 18.02 KB (0%)
3. fetchBaseQuery (esm.js) 10.91 KB (0%)
3. setupListeners (esm.js) 9.78 KB (0%)
3. ApiProvider (esm.js) 16.96 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14f758a:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

Copy link

@agusterodin agusterodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much clearer to me 👍

@Shrugsy
Copy link
Collaborator

Shrugsy commented Jul 23, 2021

@phryneas Looks good to me 👍

@phryneas phryneas merged commit 2cef448 into master Jul 23, 2021
@phryneas phryneas deleted the query-hook-docs-adjustment branch July 23, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants