-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split off signature without AsyncThunkConfig
for better inference
#1644
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4259c4b:
|
size-limit report 📦
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: 4259c4b 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61758231e4b57300088f2b02 😎 Browse the preview: https://deploy-preview-1644--redux-starter-kit-docs.netlify.app |
Yeah this is actually a lot better, i did not think of splitting the function. Also, i was afraid that such changes may cause a breakage somewhere, thus, are not allowed. So my main focus was to make it work without changing anything else as the createAsyncThunk types got so complex that they became a lot harder to grasp for those who do not know what the original authors intended them to be. Anyway, this made the reject with value recognize the return type, besides type tests are passing; so it is ready to integrate i guess? Sorry for the late reply, i have been extremely busy last week |
This supersedes #1626 and fixes #1605.
@loursbourg could you please give this a try?