Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RED-31] dev: Added new Publish-CI for Node16 ESM TypeScript #3682

Closed

Conversation

eric-crowell
Copy link
Contributor

@eric-crowell eric-crowell commented Aug 29, 2023

A part of discussion #3681

⚠️ This PR intentionally fails CI

Added a new Node16 ESM Typescript project that implements Redux Toolkit and attempts to build an ESM module with declarations.

Currently, the new project fails to build when implementing createSlice that directly uses adapter functions, asyncThunk creators, and reducer creators.

This is a test-driven approach to resolving the TypeScript portability issues for 2.0.0-beta.2.
A fix for the failing CI is intended in a subsequent PR.

RED-31

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit c72e43a
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6511a4d40d8f7c000877e8d2
😎 Deploy Preview https://deploy-preview-3682--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c72e43a:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@codesandbox
Copy link

codesandbox bot commented Aug 29, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@eric-crowell eric-crowell force-pushed the publish-ci-node-esm-ts branch from 80d6220 to da606df Compare August 30, 2023 08:47
@markerikson
Copy link
Collaborator

Just to check, did you actually file the follow-up PR you mentioned here? I don't see anything.

@eric-crowell
Copy link
Contributor Author

Just to check, did you actually file the follow-up PR you mentioned here? I don't see anything.

The intended follow-up PR originates from this discussion: #3681
In summary, it's by adding that @reduxjs/toolkit/internal entry point.

I have one more PR (#3687) to modify in order to test/prove that the Public APIs remain the same after I move things around for the fix.

If you need a time estimate for everything, I think I can get it before the end of October.

It might not be a bad idea to merge this in to ensure these errors get fixed before the next release (whichever release that is). Or I can combine this with the fix later on. However you want to approach is okay with me.

@markerikson markerikson added this to the 2.0 milestone Sep 25, 2023
@markerikson markerikson changed the title dev: Added new Publish-CI for Node16 ESM TypeScript [RED-31] dev: Added new Publish-CI for Node16 ESM TypeScript Sep 25, 2023
@markerikson
Copy link
Collaborator

FYI I'd like to get this and any related TS fixes in for 2.0, but I don't want to hard-block 2.0 on this. Any idea when you'll have time to get to it? I'm debating just pushing these until after 2.0.

@markerikson
Copy link
Collaborator

Yeah, given that these seem to be a couple CI changes and potentially adding more TS exports as the final fixes, I'm going to mark these as "Post 2.0" for now unless you have time to get to them quickly.

@markerikson markerikson modified the milestones: 2.0, Post 2.0 Oct 29, 2023
@markerikson markerikson deleted the branch reduxjs:v2.0-integration December 4, 2023 04:51
@markerikson markerikson closed this Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants