-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RED-31] dev: Added new Publish-CI for Node16 ESM TypeScript #3682
[RED-31] dev: Added new Publish-CI for Node16 ESM TypeScript #3682
Conversation
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c72e43a:
|
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
80d6220
to
da606df
Compare
Just to check, did you actually file the follow-up PR you mentioned here? I don't see anything. |
The intended follow-up PR originates from this discussion: #3681 I have one more PR (#3687) to modify in order to test/prove that the Public APIs remain the same after I move things around for the fix. If you need a time estimate for everything, I think I can get it before the end of October. It might not be a bad idea to merge this in to ensure these errors get fixed before the next release (whichever release that is). Or I can combine this with the fix later on. However you want to approach is okay with me. |
FYI I'd like to get this and any related TS fixes in for 2.0, but I don't want to hard-block 2.0 on this. Any idea when you'll have time to get to it? I'm debating just pushing these until after 2.0. |
Yeah, given that these seem to be a couple CI changes and potentially adding more TS exports as the final fixes, I'm going to mark these as "Post 2.0" for now unless you have time to get to them quickly. |
A part of discussion #3681
Added a new Node16 ESM Typescript project that implements Redux Toolkit and attempts to build an ESM module with declarations.
Currently, the new project fails to build when implementing
createSlice
that directly uses adapter functions, asyncThunk creators, and reducer creators.This is a test-driven approach to resolving the TypeScript portability issues for
2.0.0-beta.2
.A fix for the failing CI is intended in a subsequent PR.
RED-31