Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trackProperties recursion #4844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −0
Open

fix trackProperties recursion #4844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/toolkit/src/immutableStateInvariantMiddleware.ts
View file
Original file line number Diff line number Diff line change
@@ -55,6 +55,7 @@ function trackProperties(
ignorePaths,
obj[key],
childPath,
checkedObjects
)
}
}

Unchanged files with check annotations Beta

View file
packages/toolkit/src/query/tests/optimisticUpserts.test.tsx
const selectedData =
api.endpoints.postWithSideEffect.select('1')(state).data
expect(selectedData).toBe(posts[0])

Check failure on line 463 in packages/toolkit/src/query/tests/optimisticUpserts.test.tsx

GitHub Actions / Run local tests against build artifact (React ^19)

src/query/tests/optimisticUpserts.test.tsx > upsertQueryEntries > Triggers cache lifecycles and side effects 

AssertionError: expected undefined to be { id: '1', contents: 'A', title: 'A' } // Object.is equality

Ignored nodes: comments, script, style
<html>
  <head />
  <body />
</html>

- Expected: 
Object {
  "contents": "A",
  "id": "1",
  "title": "A",
}

+ Received: 
undefined

 ❯ waitFor.timeout src/query/tests/optimisticUpserts.test.tsx:463:30
 ❯ runWithExpensiveErrorDiagnosticsDisabled ../../node_modules/@testing-library/dom/dist/config.js:47:12
 ❯ checkCallback ../../node_modules/@testing-library/dom/dist/wait-for.js:124:77
 ❯ Timeout.checkRealTimersCallback ../../node_modules/@testing-library/dom/dist/wait-for.js:118:16
},
{ timeout: 50, interval: 5 },
)
View file
packages/toolkit/src/tests/immutableStateInvariantMiddleware.test.ts
const consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(noop)
try {
dispatch({ type: 'SOME_ACTION' })

Check failure on line 148 in packages/toolkit/src/tests/immutableStateInvariantMiddleware.test.ts

GitHub Actions / Run local tests against build artifact (React ^19)

src/tests/immutableStateInvariantMiddleware.test.ts > createImmutableStateInvariantMiddleware > Should print a warning if execution takes too long 

TypeError: Cannot read properties of undefined (reading 'value')
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:40
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ Object.detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:41:3
 ❯ node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:187:5
 ❯ Object.measureTime node_modules/@reduxjs/toolkit/src/utils.ts:31:12
 ❯ node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:185:16
 ❯ src/tests/immutableStateInvariantMiddleware.test.ts:148:7

Check failure on line 148 in packages/toolkit/src/tests/immutableStateInvariantMiddleware.test.ts

GitHub Actions / Run local tests against build artifact (React ^18)

src/tests/immutableStateInvariantMiddleware.test.ts > createImmutableStateInvariantMiddleware > Should print a warning if execution takes too long 

TypeError: Cannot read properties of undefined (reading 'value')
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:40
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:138:20
 ❯ Object.detectMutations node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:41:3
 ❯ node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:187:5
 ❯ Object.measureTime node_modules/@reduxjs/toolkit/src/utils.ts:31:12
 ❯ node_modules/@reduxjs/toolkit/src/immutableStateInvariantMiddleware.ts:185:16
 ❯ src/tests/immutableStateInvariantMiddleware.test.ts:148:7
expect(consoleWarnSpy).toHaveBeenCalledOnce()