Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove initial assignment of
dispatch
in applyMiddleware to make it…
… more expressive * separate local variables in applyMiddleware to make it more expressive In the original version, the `dispatch` local variable in applyMiddleware stands for different things before and after the `compose` call. It'd be more expressive to separate "the original one on store" and "the one with middlewares applied" * refactor to make `applyMiddleware` clearer pass `store.dispatch` to `compose`, not through another local variable
- Loading branch information
9496fd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaearon Just wanted to let you know that this change hit npm and broke our build (which stupidly was referencing the version "^3.3.1") with an error about _dispatch not being a function. I only say this in case it's helpful feedback, as we resolved it on our end by ceasing use of the carrot in the version.
9496fd7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, thanks. Fixed this in 3.5.1.