Update to Usage With React documention #1186
Conversation
| @@ -52,18 +52,16 @@ It is advisable that only top-level components of your app (such as route handle | |||
| </tbody> | |||
| </table> | |||
|
|
|||
| In this todo app, we will only have a single container component at the top of our view hierarchy. In more complex apps, you might have several of them. While you may nest container components, we suggest that you pass props down whenever possible. | |||
| In this todo app, we will have three container components that pass props to presentational components. We suggest that you do not nest container components and that you pass props down whenever possible. | |||
There was a problem hiding this comment.
I'd say "We suggest that you do not nest container components beyond necessity. Start by having a few top-level container components pass the props down to the presentational component tree. When you notice that components in the middle of that tree pass too many props down without actually using them, it is a good time to introduce some containers."
There was a problem hiding this comment.
Thanks. I have updated PR.
|
|
||
| These are all presentational components. They don’t know *where* the data comes from, or *how* to change it. They only render what’s given to them. | ||
|
|
||
| If you migrate from Redux to something else, you’ll be able to keep all these components exactly the same. They have no dependency on Redux. | ||
|
|
||
| Let’s write them! We don’t need to think about binding to Redux yet. You can just give them fake data while you experiment until they render correctly. | ||
| We also have some container components that connects to Redux. The container components are responsible for getting and transforming state. Remember that changes result in a new state as state is immutable. |
There was a problem hiding this comment.
I think "getting and transforming state" is a bit confusing. Changes happen in reducer, so I'm not sure why the next sentence is relevant here.
Maybe something like "Container components calculate the props to pass to the presentational components they wrap based on the current state of the Redux store." could work better instead.
|
Thanks for your work on this! I left some comments. Also, |
|
@gaearon Thanks, I'll update your comments this weekend. I also have the source code to match. Would you have time to review https://github.com/urbanvikingr/todo. Would you it to be transferred to this repo? |
|
Thank you very much. I continued your work in #1285. |
The documentation UsageWithReact.md has been updated with code samples according to Egghead.io video series. A complete sample app can be found here https://github.com/urbanvikingr/todo. Please tell me how you would like to bring it to Rackt.