Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package.json main script path #1683

Closed
wants to merge 1 commit into from
Closed

Fix package.json main script path #1683

wants to merge 1 commit into from

Conversation

JanCVanB
Copy link

Update main script path in package.json to reference src/, not lib/.

Update `main` script path in `package.json` to reference `src/`, not `lib/`.
@TrySound
Copy link
Contributor

@jvanbrug src is es2015 code which doesn't work in all environments. lib contains code processed with babel, es contains processed code but with es2015-modules. Your PR doesn't make sense.

@mxstbr
Copy link
Contributor

mxstbr commented Apr 30, 2016

The current behaviour is correct, as @TrySound mentioned, we want to give users access to the processed code, not the source! If users don't have an ES* transpiler and we only give them access to the source, they aren't able to use it, which we want to avoid.

Thanks for taking the time to submit this PR, we appreciate it a lot!

@mxstbr mxstbr closed this Apr 30, 2016
@JanCVanB
Copy link
Author

JanCVanB commented May 1, 2016

Noob PR, thanks for the insight!

@gaearon
Copy link
Contributor

gaearon commented May 1, 2016

No problem. Thanks for taking the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants