-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(dependencies) Update symbol-observable requirement to 1.0.2 #1877
Conversation
Test failed because symbol-observable used 'default' (as usually proceed by babel) and es3 checker detects this. Actual patch: Index: dist\redux.js
===================================================================
--- dist\redux.js
+++ dist\redux.js
@@ -917,9 +917,9 @@
var _ponyfill = __webpack_require__(14);
var _ponyfill2 = _interopRequireDefault(_ponyfill);
- function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { "default": obj }; }
var root = undefined; /* global window */
if (typeof global !== 'undefined') {
@@ -927,10 +927,10 @@
} else if (typeof window !== 'undefined') {
root = window;
}
- var result = (0, _ponyfill2.default)(root);
- exports.default = result;
+ var result = (0, _ponyfill2["default"])(root);
+ exports["default"] = result;
/* WEBPACK VAR INJECTION */}.call(exports, (function() { return this; }())))
/***/ },
/* 14 */
@@ -940,9 +940,9 @@
Object.defineProperty(exports, "__esModule", {
value: true
});
- exports.default = symbolObservablePonyfill;
+ exports["default"] = symbolObservablePonyfill;
function symbolObservablePonyfill(root) {
var result;
var _Symbol = root.Symbol;
|
So, should this be fixed in |
I opened a PR for it over there (benlesh/symbol-observable#22) Cool that the module does its job! 😀 |
@SimenB thanks. I actually was not sure, if symbol-observable commiters interested in es3 syntax support. Waiting now for merging. |
👍 @btd you are 2 days faster than me 👅 |
I think benlesh/symbol-observable#22 should get merged first? |
Oops sorry it was already mentioned in this thread 😛 |
@gaearon i updated commit to 1.0.2 |
Thanks! |
@timdorr can i get this published to npm? |
No description provided.