-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port examples to use Create React App #1883
Conversation
RIP #1800 |
😅 |
@gaearon I know you're working on this and I have a suggested improvement. Should I go ahead an create a PR myself? |
What kind of improvement? |
Well improvement might not really be the word :) There's an unused import in todo-with-undo's index.js file: Another thing that caught my eye is the use of double quotes in |
Feel free to send a PR for this.
I'll clean up style according to our lint config before merging. |
Great, thanks a lot for the help |
Hmm, not sure why that last change didn't fix the build. Well, I tried! |
I have noticed that every component under the shopping cart example is a stateless component but they all are defined with the |
I found some more stuff in the shopping cart example. But I don't really feel comfortable hijacking @gaearon's PR with my questions all the time and I will go through all of the examples in detail during the weekend. |
@canibanoglu I left the branch in #1800 untouched. So if you see anything in there you want to pull from, that's fine. We'll do a PR to update the examples after this one cleans up the build infrastructure. |
Alright I'll send my PRs to that branch then. Thank you very much for you help! |
f53b786
to
e5c266f
Compare
Going to Just Do This. |
* Rename examples => examples_old * Port counter and counter-vanilla * Port async example * Port todos example * Port todos-with-undo example * Port some tests over * Add todomvc example * Ported shopping-cart example * Ported tree-view * Ported real-world * Add missing dep * Temp fix install until examples get an equivalent to buildAll.js * Restore example build scripts. * Bump react-scripts * Finish porting examples
Work in progress.
This is a good opportunity to dogfood the tool!