Enable support for Mozilla Addons #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, that's a good point. I think it's less about supporting the FF addon environment and more about supporting browser environments without assuming polyfills are provided. Good call! |
|
I'm confused by this. Does this still strip out the DEV code in production? Is Uglify smart enough to figure out what's going on here? |
|
Please see #2244. |
Merged
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redux seems to be great solution for managing state of browser extensions. Unfortunately it doesn't work properly with Firefox addons, because it requires global process object which is not available inside addon environment. This applies to both web-extensions and jetpack-based addons. In case of web-extensions it is possible make polyfill for process object, but it is not possible with jetpack (at least without using custom modules loader).
I've fixed this issue by checking if process object exists before using it. There was also issue with one of dependencies - symbol-observable - but it was fixed yesterday.