-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove filtering inside compose #2167
Conversation
As a developer I expect my code to throw an Error, not eat it. Also I strongly opposite to extra useless computations in redux. Why not to filter functions outside of |
But throwing errors explicitly is definitely a better thing. |
What if it were to only filter out falsey? |
One can filter everything he wants to outside of compose. It's so easy I can't even |
Good points being made. Thanks! |
compose
does not have the well know definition of this function as like as in your comments https://github.com/reactjs/redux/blob/master/src/compose.js#L7-L9So I suggest you to remove this line.