-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TS definitions test for new Dispatch typing #2674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By and large it's equivalent, but these definitions aren't quite right: // dispatch.ts
declare module "../../" {
export interface Dispatch<D = Action> {
<R>(asyncAction: (dispatch: Dispatch<D>, getState: () => D) => R): R;
// ^ `getState()` should not return the action type `D`
}
} // middleware.ts
declare module "../../" {
export interface Dispatch<D> {
<R,S>(asyncAction: (dispatch: Dispatch<D>, getState: () => S) => R): R;
// ^ `getState()` should not be parameterized by the state type `S`; the type
// of the state is not determined by the caller
}
} |
Thanks. I'm starting to get my bearings with TS stuff, but our typings are really dense and I need some hand-holding :) I think this looks good. Since we're now passing, this should get my other PRs unblocked. Thank you! |
No problem, looking forward to seeing these typings on |
timdorr
pushed a commit
that referenced
this pull request
Oct 23, 2017
* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
timdorr
pushed a commit
that referenced
this pull request
Nov 3, 2017
* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
timdorr
pushed a commit
that referenced
this pull request
Nov 16, 2017
* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
seantcoyote
pushed a commit
to seantcoyote/redux
that referenced
this pull request
Jan 14, 2018
* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
tomipaul
pushed a commit
to tomipaul/redux
that referenced
this pull request
Apr 8, 2018
* Fix TypeScript definitions test for new Dispatch typing * Be explicit about type parameters
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.