-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inital setup of docusaurus #3165
Conversation
Hmm. Well, we can't move the actual README, because that's gotta stay at the root of the repo. PATRONS could be moved, and tbh CHANGELOG is kinda pointless. Tell you what. Let's not include PATRONS or CHANGELOG in the actual published docs. Leave the files there for historical purposes, but no point in publishing them. For the README... do we even want the entire README as a docs page itself? I'm not sure we do. Perhaps we should have a cut-down version of it in the docs. |
website/siteConfig.js
Outdated
*/ | ||
|
||
// This copyright info is used in /core/Footer.js and blog RSS/Atom feeds. | ||
copyright: `Copyright © ${new Date().getFullYear()} Your Name or Your Company Name`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fill this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you want it to say? "Redux JS"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the license (which covers the existing docs), Copyright (c) 2015-present Dan Abramov
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, maybe we should get a little more specific. Dan doesn't own copyright for things he didn't contribute. Copyright (c) 2015-present Dan Abramov and the Redux documentation authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice. Fixed now.
.gitignore
Outdated
|
||
website/translated_docs | ||
website/build/ | ||
website/yarn.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use Yarn. We use npm here. Also, don't ignore the lock file generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted
Should we create an issue to cover what needs to be done? Needs to be done:
|
Deploy preview for redux-docs ready! Built with commit 89faca9 |
Looks like Docusaurus just merged in the nested categories feature in facebook/docusaurus#892, and v1.4.1 should be out with that in the next few days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the duplicate comments. There isn't a way to edit multiple files in a single commit from the web UI, so I'm just noting the places that are affected in the review UI for now.
docs/introduction/CoreConcepts.md
Outdated
--- | ||
id: core-consepts | ||
title: Core consepts | ||
sidebar_label: Core consepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
--- | ||
id: prerequisite-consepts | ||
title: Prerequisite Consepts | ||
sidebar_label: Prerequisite Consepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
website/core/Footer.js
Outdated
<div> | ||
<h5>Docs</h5> | ||
<a href={this.docUrl("introduction/core-consepts")}> | ||
Core consepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
website/pages/en/index.js
Outdated
<ProjectTitle /> | ||
<PromoSection> | ||
<Button href={docUrl("introduction/core-consepts", language)}> | ||
Core consepts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
website/sidebars.json
Outdated
"docs": { | ||
"Introduction": [ | ||
"introduction/motivation", | ||
"introduction/core-consepts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
website/sidebars.json
Outdated
], | ||
"Structuring Reducers": [ | ||
"recipes/structuring-reducers", | ||
"recipes/reducers/prerequisite-consepts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
website/siteConfig.js
Outdated
|
||
// For no header links in the top nav bar -> headerLinks: [], | ||
headerLinks: [ | ||
{ doc: "introduction/core-consepts", label: "Docs" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: "concepts"
What a great god damn effort @sveinpg 👏 👏 👏 |
The only thing I don't like about this site so far: The sidebar position resets after navigating to a new page. If I'm way down at the API reference and click over from createStore to the Store, the sidebar is back at the top. Also, for the "README", I'd like to see that be a "Getting Started" page that can replace the "Core Concepts" button on the front page. And that should contain just the bare minimum to make a store and dispatch actions. Simple and straightforward for those that don't want to read through many pages of docs 😄 |
There is a workaround for the sidebar scroll position |
@sveinpg Hi there, Docusaurus maintainer here. We managed to get the subcategories feature shipped in facebook/docusaurus#1026 and you should be able to keep the subcategories for "Structuring Reducers". Could you point your Docusaurus version to trunk for the moment? If there are things that Redux needs but Docusaurus doesn't support we could do it over the weekend. Else if all is good, I'll release Docusaurus 1.5.0 over the weekend which will include the subcategories feature. Let me know what you think! We're here to support Redux's migration to Docusaurus 😄 |
@yangshun How do I point my docusaurus version to trunk? |
website/package.json
Outdated
"rename-version": "docusaurus-rename-version" | ||
}, | ||
"devDependencies": { | ||
"docusaurus": "^1.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this line to:
"docusaurus": "git://github.com/facebook/docusaurus.git#127500532103ee9096de9f202866546969ea107d"
Refer to https://stackoverflow.com/a/18049685/1751946 for more info.
Docusaurus v1.5.0 has been released - https://github.com/facebook/Docusaurus/blob/master/CHANGELOG.md#150---2018-10-13 @sveinpg was trying out the trunk version yesterday and he showed me that the subcategories worked ok! Thanks for your patience! |
Okay, I just took a look at the current contents. It looks great! I think this is more than sufficient to merge into the @sveinpg , thank you VERY much for some excellent work! |
* Added metadata to the docs * Added initial docusaurus setup * Removed markdown block * Updated copyright * Removed yarn.lock from gitignore * Updated copyright * . * Add copyright to footer * Added white version of redux-icon to the header * Updated image urls to use https * Fixed spelling * Added script to scroll active sidebar in to viewport. * Moved content from README to a getting started section. * Replaced core concepts link with getting started * Updated docusaurus to 1.5.0 * Moved Structuring Reducers to a subcategory in the sidebar
#3161
Added inital setup of docusaurus.
Missing files in docs:
README.md
PATRONS.md
CHANGELOG.md
Docusaurus requires docs to be placed in
/docs
. Should we move these files?Also, since docusaurus currently does not support nested sidebars, I moved
Structuring Reducers
one level up in the sidebar.