Iterate using for in instead of Object.keys and minor fixes #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-docs ready! Built with commit 235aa07 |
|
Not a huge deal, but why not. Thanks! |
kiku-jw
pushed a commit
to kiku-jw/redux
that referenced
this pull request
Apr 6, 2019
…3371) * Iterate using for in * Use single quotes for string literals without interpolation * Fix punctuation. * Limit node version until we update jest. Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
This was referenced Sep 23, 2019
This was referenced Mar 11, 2020
This was referenced Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though this code has no impact on the overall performance of the application
for inis faster in modern browsers (https://jsperf.com/object-keys-vs-for-in-with-closure/138).I propose this change only as readability improvement.