Allow Redux to be imported as type="module"
#3389
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd all love to import Redux as
type="module"
natively in the browser, however theprocess.env
and thesymbol-observable
ponyfill make that problematic.By checking for the existence of
symbol-observable
ourselves — rather than delegating it to a module unless we really need to — as well as checking fortypeof process
we can make it happen.Redux is a simple enough library. Let's all be standards compliant, friends (or as close as we can at this point)! 🍻
Discuss...