-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer to rollup TS plugin to build types #3564
Conversation
I don't want to name the index file something other than |
|
I think the only way to make you happy is to do some manual renaming after the rollup build. |
3600edf
to
17fa65a
Compare
@@ -4,7 +4,7 @@ import { | |||
Dispatch, | |||
bindActionCreators, | |||
ActionCreatorsMapObject | |||
} from 'redux' | |||
} from '../..' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This could have caused a number of problems for people working on the code!
This also puts them back into the types path. However, I don't know how to have them output as a single file bundle to match our other outputs.
OK, made a change to only put out the declarations once, as they were showing up in each of the output types. Here's what things look like now:
I don't know how to get the declarations to be flat like the other output bundles, or if that's even really possible. I don't think it's super-necessary, so this is looking good as-is. Thanks for following up on this @jedmao! |
Just so you know, this fixes duplication, but it still breaks direct imports or imports that go deeper than "redux". e.g., |
We haven't supported direct imports since moving to flat bundles. |
* Defer to rollup TS plugin to build types * index.ts -> redux.js, redux.d.ts * Only output one copy of the types. This also puts them back into the types path. However, I don't know how to have them output as a single file bundle to match our other outputs. * Remove the move Co-authored-by: Tim Dorr <git@timdorr.com> Former-commit-id: 75c882b Former-commit-id: aaa10aa
* Defer to rollup TS plugin to build types * index.ts -> redux.js, redux.d.ts * Only output one copy of the types. This also puts them back into the types path. However, I don't know how to have them output as a single file bundle to match our other outputs. * Remove the move Co-authored-by: Tim Dorr <git@timdorr.com> Former-commit-id: 75c882b Former-commit-id: aaa10aa
Same as cellog#1