Cached Object string representation #942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling toString on Object may cost a lot. It's much better to have cached value for it.
Contributor
|
In general we don't want to diverge from Lodash implementation because we're going to eventually use it (#611). Can you update the code to what Lodash uses in 4.0 instead? |
Contributor
Author
|
Not sure if it's a good idea. Looks like in lodash isPlainObject has internal dependencies. |
Contributor
|
Seems straightforward enough. |
gaearon
added a commit
that referenced
this pull request
Oct 23, 2015
Cached Object string representation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling toString on Object may cost a lot. It's much better to
have cached value for it.