Skip to content

Commit

Permalink
Enable noImpilictAny for TypeScript definition tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@aikoven
aikoven committed Nov 21, 2016
1 parent 0aed9b7 commit dd1003f
Show file tree
Hide file tree
Showing 3 changed files with 90 additions and 59 deletions.
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,6 @@
"ncp": "^2.0.0",
"nyc": "^6.4.0",
"typescript": "^2.1.1",
"typings-tester": "^0.1.0"
"typings-tester": "^0.2.0"
}
}
146 changes: 88 additions & 58 deletions typescript_test/test.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function testConnect() {
const connected = connect(
createSelector(
(state: {foo: string}) => state.foo,
(state, props: {bar: number}) => state.bar,
(state: never, props: {bar: number}) => props.bar,
(foo, bar) => ({foo, baz: bar}),
)
)(props => {
Expand Down Expand Up @@ -87,17 +87,18 @@ function testInvalidTypeInCombinator() {
}

function testRestParameters() {
type MyState = {foo: string, bar: number};
createSelector(
(state: {foo: string, bar: number}) => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.bar,
state => state.bar,
state => state.bar,
state => state.bar,
state => state.bar,
(state: MyState) => state.foo,
(state: MyState) => state.foo,
(state: MyState) => state.foo,
(state: MyState) => state.foo,
(state: MyState) => state.foo,
(state: MyState) => state.bar,
(state: MyState) => state.bar,
(state: MyState) => state.bar,
(state: MyState) => state.bar,
(state: MyState) => state.bar,
(foo1: string, foo2: string, foo3: string, foo4: string, foo5: string,
bar1: number, bar2: number, bar3: number, bar4: number, bar5: string) => {
}
Expand All @@ -110,7 +111,7 @@ function testParametricSelector() {

const selector = createSelector(
(state: State) => state.foo,
(state, props: Props) => props.bar,
(state: never, props: Props) => props.bar,
(foo, bar) => ({foo, bar}),
);

Expand Down Expand Up @@ -141,8 +142,8 @@ function testParametricSelector() {
function testArrayArgument() {
const selector = createSelector([
(state: {foo: string}) => state.foo,
state => state.foo,
(state, props: {bar: number}) => props.bar,
(state: {foo: string}) => state.foo,
(state: never, props: {bar: number}) => props.bar,
], (foo1, foo2, bar) => ({foo1, foo2, bar}));

const ret = selector({foo: 'fizz'}, {bar: 42});
Expand All @@ -164,36 +165,37 @@ function testArrayArgument() {
// typings:expect-error
createSelector([
(state: {foo: string}) => state.foo,
state => state.foo,
(state: {foo: string}) => state.foo,
], (foo: string, bar: number) => {});

createSelector([
(state: {foo: string}) => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
], (foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, foo9, foo10) => {
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
], (foo1: string, foo2: string, foo3: string, foo4: string, foo5: string,
foo6: string, foo7: string, foo8: string, foo9: string, foo10: string) => {

});

// typings:expect-error
createSelector([
(state: {foo: string}) => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
], (foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8: number, foo9, foo10) => {

});
Expand All @@ -213,41 +215,69 @@ function testArrayArgument() {

const selector2 = createSelector([
(state: {foo: string}) => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
], (foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, foo9) => {
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
], (foo1: string, foo2: string, foo3: string, foo4: string, foo5: string,
foo6: string, foo7: string, foo8: string, foo9: string) => {
return {foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, foo9};
});

selector2({foo: 'fizz'});
{
const ret = selector2({foo: 'fizz'});
const foo1: string = ret.foo1;
const foo2: string = ret.foo2;
const foo3: string = ret.foo3;
const foo4: string = ret.foo4;
const foo5: string = ret.foo5;
const foo6: string = ret.foo6;
const foo7: string = ret.foo7;
const foo8: string = ret.foo8;
const foo9: string = ret.foo9;
// typings:expect-error
ret.foo10;
}

// typings:expect-error
selector2({foo: 'fizz'}, {bar: 42});

const parametric = createSelector([
(state: never, props: {bar: number}) => props.bar,
(state: {foo: string}) => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
state => state.foo,
(state, props: {bar: number}) => props.bar,
], (foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, bar) => {
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
(state: {foo: string}) => state.foo,
], (bar: number, foo1: string, foo2: string, foo3: string, foo4: string,
foo5: string, foo6: string, foo7: string, foo8: string) => {
return {foo1, foo2, foo3, foo4, foo5, foo6, foo7, foo8, bar};
});

// typings:expect-error
parametric({foo: 'fizz'});

parametric({foo: 'fizz'}, {bar: 42});
{
const ret = parametric({foo: 'fizz'}, {bar: 42});
const foo1: string = ret.foo1;
const foo2: string = ret.foo2;
const foo3: string = ret.foo3;
const foo4: string = ret.foo4;
const foo5: string = ret.foo5;
const foo6: string = ret.foo6;
const foo7: string = ret.foo7;
const foo8: string = ret.foo8;
const bar: number = ret.bar;
// typings:expect-error
ret.foo9;
}
}

function testDefaultMemoize() {
Expand All @@ -260,8 +290,8 @@ function testDefaultMemoize() {
const ret1: string = memoized('42');

const memoized2 = defaultMemoize(
(str: string, arr: string[]) => ({str, arr}),
(a, b, index) => {
(str: string, arr: string[]): {str: string, arr: string[]} => ({str, arr}),
<T>(a: T, b: T, index: number) => {
if (index === 0)
return a === b;

Expand All @@ -288,7 +318,7 @@ function testCreateSelectorCreator() {

const parametric = createSelector(
(state: {foo: string}) => state.foo,
(state, props: {bar: number}) => props.bar,
(state: never, props: {bar: number}) => props.bar,
(foo, bar) => ({foo, bar}),
);

Expand All @@ -302,7 +332,7 @@ function testCreateSelectorCreator() {
// typings:expect-error
createSelectorCreator(defaultMemoize, 1);

createSelectorCreator(defaultMemoize, (a, b, index) => {
createSelectorCreator(defaultMemoize, <T>(a: T, b: T, index: number) => {
if (index === 0)
return a === b;

Expand Down
1 change: 1 addition & 0 deletions typescript_test/tsconfig.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"module": "commonjs",
"noImplicitAny": true,
"strictNullChecks": true
}
}

0 comments on commit dd1003f

Please sign in to comment.