Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing typescript typing for createSelector method with array of… #216

Closed
wants to merge 1 commit into from

Conversation

pyu10055
Copy link

@pyu10055 pyu10055 commented Feb 2, 2017

… selectors

@coveralls
Copy link

coveralls commented Feb 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 8a28c32 on pyu10055:master into 1143dcb on reactjs:master.

@codecov-io
Copy link

Codecov Report

Merging #216 into master will not impact coverage.

@@          Coverage Diff          @@
##           master   #216   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          12     12           
=====================================
  Hits           12     12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1143dcb...8a28c32. Read the comment docs.

@aikoven
Copy link
Contributor

aikoven commented Feb 3, 2017

Please see #192

@pyu10055
Copy link
Author

pyu10055 commented Feb 3, 2017

@aikoven the PR in #192 still does not define the method signature for array of selector AFAICT. And the conversation is quite long, can you elaborate what is the plan for supporting that? Thanks.

@ellbee
Copy link
Collaborator

ellbee commented Mar 6, 2017

@aikoven Can this be closed?

@aikoven
Copy link
Contributor

aikoven commented Mar 7, 2017

I guess so.

@pyu10055 do you still have any concerns?

@ellbee
Copy link
Collaborator

ellbee commented Mar 9, 2017

I'll close this.

@pyu10055 Feel free to re-open if you think there is a still a problem.

@ellbee ellbee closed this Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants