Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Callable Type Signature for Memoize in createSelectorCreator #465

Closed
wants to merge 1 commit into from

Conversation

micahbales
Copy link
Contributor

@micahbales micahbales commented Jul 30, 2020

Addresses microsoft/TypeScript#20007 by adding a callable type signature for the memoize callback in createSelectorCreator. This avoids a type error when using Lodash Memoize as the first argument in createSelectorCreator

…ator

Addresses issue #20007 by adding a callable type signature for the memoize callback in createSelectorCreator. This avoids a type error when using Lodash Memoize as the first argument in createSelectorCreator
@marchaos
Copy link

Any chance we can revisit this PR ?

@spassvogel
Copy link

It's been a year since this repo has had any updates. Probably it's a dead end..

@nickserv
Copy link
Contributor

nickserv commented Feb 8, 2021

I think if we were to update these types, it would be best to map them to the returned types as well.

@eXamadeus eXamadeus mentioned this pull request Feb 8, 2021
3 tasks
@eXamadeus
Copy link
Contributor

eXamadeus commented Feb 8, 2021

@nickmccurdy:
I think if we were to update these types, it would be best to map them to the returned types as well.

So I pulled this change into #486. I'm not sure what you mean by mapping them to the returned types. Isn't F the type of the input and the return? Or am I grossly misunderstanding something?

Any updates to this PR can easily be pulled into #486 or we can do the changes directly in #486. Not sure of your preference.

@markerikson
Copy link
Contributor

Closing since this is now included in #486 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants