Allow passing in memoize functions directly to `createSelector`. #626

… to override the initial memoize function passed in to createSelectorCreator

…reator` in order to simplify the types. I ran the all the type tests without it and it seems it can be removed without sacrificing any sort of type safety on any level. When calling `createSelectorCreator`, it doesn't need to know the type of the function it's memoizer at some point will memoize, it can be inferred later.

…ds in order to keep the types simple. I also removed `MemoizeOptions` from the `CreateSelectorFunction` interface and `createSelectorCreator` since its type can be derived directly from `MemoizeFunction`.

…ator I tried to get the types for `createSelectorCreator` to work with the new memoizeOptions type parameter without using overloads, but TS was still allowing passing in a second argument when the first argument is the memoizeOptions object. So I had to resort to using overloads. Might try again later to see if it's possible to make it work with only generics and conditionals.

…ncies` Will try to add more inline documentation and JSDocs to types and functions.

…Memoize`

…ions I tested different variations of CreateSelectorOptions and CreateSelectorFunction. From what I've learned so far, it seems like CreateSelectorFunction can do fine with just one generic which is MemoizeFunction. It can derive the rest of the types as needed. CreateSelectorOptions now uses the MemoizeFunction generic type in addition to OverrideMemoizeFunction and OverrideArgsMemoizeFunction in order to create the type for the memoizeOptions object. Will investigate to see if CreateSelectorFunction can work with a `State` and `MemoizeFunction` generic type parameter.

UnknownFunction kind of sounds like it's a function that has parameters of type unknown. So for the sake of semantic consistency I will create another type called UnknownFunction which will have parameters of type unknown.

I also created UnknownFunction which has parameters of type unknown.

Will add more JSDoc to all types and function signatures.

The `Keys` generic type parameter was causing type mismatches for selectors created using other third party memoize methods such as `microMemoize` and `memoizeOne`. The types did not have the output selector fields attached to the selectors. Once I removed Keys, the type mismatch was resolved.

The type parameter for the first overload of `createSelectorCreator` looks quite messy, but it works. I will try and simplify it later to make it more readable.

There were some issues with `CreateSelectorOptions` not inferring the type of `memoizeOptions` or `argsMemoizeOptions` all the way and it would sometimes give implicit any errors on the `equalityCheck` and `resultEqualityCheck` functions.

Sometimes `CreateSelectorFunction` would not infer the type of the extra fields that memoizers return like `clearCache` for `defaultMemoize` or `isMemoized`. I added another generic type parameter called `ArgsMemoizeFunction` which is exactly what it sounds like, it is the type of `argsMemoize`. It was necessary to add this type parameter since it can directly impact the return type of the selector, specifically the extra memoizer fields that selectors return. e.g: clearCache, cache, isMemoized, etc.

… `CreateSelectorOptions` This was done to maintain a single source of truth in case the types were to change later.

- Added `IfNever` utility type to help conditionally resolve the type of a `memoizeOptions` object based on whether `memoize` is provided or not. - Added `Fallback` utility type to help detect whether a memoize function is to be overridden inside the options argument of `createSelector`. - Added `OverrideMemoizeOptions` utility type to help derive the type of `memoizeOptions` and `argsMemoizeOptions` based on whether `memoize` and `argsMemoize` were overridden.

- Add `assertIsFunction` which is basically just a small part of code inside `createSelectorCreator` extracted to make the function body smaller and easier to read, and to add a small layer of type safety and reusability at the same time. - Add `ensureIsArray` which is another small part of code inside `createSelectorCreator`. But since it is a pattern that we repeat, it does not hurt to turn it into a function that we can reuse. - Move `getDependencies` to utils.ts and change its `Error` to `TypeError` in order to be more explicit.

…r own files This was done because the new overload signature for `createSelectorCreator` was added and the index.ts file was getting a little too crowded.

…electorCreator`

Change `DropFirst` from a type that drops the first item in an array to a type that drops the first parameter in a function, and rename it to `DropFirstParameter`. This change was mostly due to the fact that the type was essentially a duplicate of the internal utility type `Tail`.

Instead of taking a `Combiner` and a `Keys` generic type parameter, it now takes 4 generic parameters: - `Result`: the return value of `resultFunc`. - `Selectors`: the input selectors. This enables us to infer the type of `dependencies` as well. - `MemoizeFunction`: the memoize function used to infer the correct type for `memoizedResultFunc` and the new `memoize` output selector field. - `ArgsMemoizeFunction`: the memoize function used for the new `argsMemoize` output selector field.

It now takes the exact same generic type parameters as `OutputSelectorFields` which in turn simplifies the return type of `CreateSelectorFunction`.

Remove the `Combiner` and `Keys` generic type parameters from `OutputParametricSelector` as they are no longer needed.

This was done because now there are other types such as `OutputSelectorFields` that need to use it.

- Rename `Fallback` to `FallbackIfNever`. - Add the source for `IfNever` and `OmitIndexSignature` and move them to External/Copied Utility Types section. - Rename `MemoizeOptsFromParams` to `MemoizeOptionsFromParameters`. - Update the description for `AnyFunction` to be more explicit. - Remove union with `never` in the `Params` generic type parameter of `Selector` since a union of `any[]` and `never` is just `any[]`.

…nimize repetition.

The previous conditional type can be slightly simplified since the condition itself only applies to `Params`

It would make more sense if `Selectors` came before `Result` since that actually corresponds to the order of execution inside `createSelector`.

*`runStabilityCheck` is the extracted logic of running stability checks inside `createSelectorCreator` made into its own standalone function. It made sense to segregate this piece of logic from the body of `createSelectorCreator` as it has its own purpose somewhat independently from the rest of the function. *`collectInputSelectorResults` is another piece of logic extracted from the body of `createSelectorCreator`. It only focuses on creating an array from the return values of input selectors.

- Made the following changes to enhance readability: * Add JSDocs to some of the types. * Rename some variables. * Rename some types. * Rename some generic type parameters. * Rename some parameter names. * Tweak some existing JSDocs.

Substituted `deepClone` since Node 16 does not support `structuredClone`.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow passing in memoize functions directly to `createSelector`. #626

Allow passing in memoize functions directly to `createSelector`. #626

Commits on Oct 28, 2023

Allow passing in memoize functions directly to createSelector. #626

Allow passing in memoize functions directly to createSelector. #626

Commits on Oct 28, 2023

Allow passing in memoize functions directly to `createSelector`. #626

Allow passing in memoize functions directly to `createSelector`. #626