Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match resetRecomputations and resetDependencyRecomputations behavior to their types #646

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Match resetRecomputations and resetDependencyRecomputations behavior to their types #646

merged 1 commit into from
Nov 28, 2023

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Fixes resetRecomputations and resetDependencyRecomputations runtime behavior so that they return void instead of 0 which is the intended behavior.
  • Removes unit tests checking to see if these functions return 0.

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 147a30e:

Sandbox Source
JavaScript Configuration
Vanilla Typescript Configuration

@markerikson markerikson merged commit 4314dca into reduxjs:master Nov 28, 2023
15 checks passed
@aryaemami59 aryaemami59 deleted the reset-functions branch December 17, 2023 13:20
@OKEAMAH OKEAMAH mentioned this pull request May 26, 2024
Merged
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
@lucentlabz lucentlabz mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaemami59 @markerikson