Switch createSelector to use weakMapMemoize by default #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markerikson
force-pushed
the
feature/5.0-weakmapmemoize-default
branch
from
861ef6b
to
82cc630
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10b6753:
|
markerikson
force-pushed
the
feature/5.0-weakmapmemoize-default
branch
3 times, most recently
from
885ad9f
to
f6fc5fd
Compare
markerikson
force-pushed
the
feature/5.0-weakmapmemoize-default
branch
from
f6fc5fd
to
1256e80
Compare
markerikson
force-pushed
the
feature/5.0-weakmapmemoize-default
branch
from
d702de1
to
a03173f
Compare
markerikson
force-pushed
the
feature/5.0-weakmapmemoize-default
branch
from
68a8f77
to
10b6753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
createSelectorto useweakMapMemoizeby defaultThe code changes are simple. The unit test changes are mostly "look at what the numbers are now and use those assertions instead".