Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce pre-typed createStructuredSelector via createStructuredSelector.withTypes<RootState>() method #678

Merged
merged 21 commits into from
Jan 5, 2024
Merged

Introduce pre-typed createStructuredSelector via createStructuredSelector.withTypes<RootState>() method #678

merged 21 commits into from
Jan 5, 2024

Commits on Jan 4, 2024

  1. Add initial implementation of createStructuredSelector.withTypes

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b4439a9 View commit details
    Browse the repository at this point in the history

  2. Add type tests for createStructuredSelector.withTypes

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0f6bb10 View commit details
    Browse the repository at this point in the history

  3. Add runtime unit tests for createStructuredSelector.withTypes

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d3464d8 View commit details
    Browse the repository at this point in the history

  4. Add additional type tests for createStructuredSelector.withTypes

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    605e46a View commit details
    Browse the repository at this point in the history

  5. Add type tests for StructuredSelectorCreator

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    d9fcb15 View commit details
    Browse the repository at this point in the history

  6. Change SelectorsObject from interface with index signature to `Reco… 

    …rd` type
    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e7f39ca View commit details
    Browse the repository at this point in the history

  7. Change createStructuredSelector.withTypes type to arrow function 

      - This was mainly done because `@typescript-eslint/eslint-plugin` has a rule called `@typescript-eslint/unbound-method`, which results to a lint error.
    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    c0f7c8a View commit details
    Browse the repository at this point in the history

  8. Change createSelector.withTypes type to arrow function 

      - This was mainly done because `@typescript-eslint/eslint-plugin` has a rule called `@typescript-eslint/unbound-method`, which results to a lint error.
    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    68a119b View commit details
    Browse the repository at this point in the history

  9. Add createStructuredSelector.withTypes example for docs

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    37ebaf8 View commit details
    Browse the repository at this point in the history

  10. Add JSDocs for StateType generic type parameter in `StructuredSelec… 

    …torCreator`
    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    986ca8a View commit details
    Browse the repository at this point in the history

  11. Add JSDocs for StateType generic type parameter in SelectorsObject

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    121fc36 View commit details
    Browse the repository at this point in the history

  12. Add JSDocs for createStructuredSelector.withTypes

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    25544d7 View commit details
    Browse the repository at this point in the history

  13. Fix typos inside docs

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8b93622 View commit details
    Browse the repository at this point in the history

  14. Deprecate TypedStructuredSelectorCreator

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4cc0883 View commit details
    Browse the repository at this point in the history

  15. Fix typos inside docs

    @aryaemami59
    aryaemami59 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3e39fcc View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Modify JSDocs for TypedStructuredSelectorCreator 

      - The description was removed since it was not accurate in describing what the type does,
    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7f1588c View commit details
    Browse the repository at this point in the history

  2. Add todo comments to remove certain test blocks 

      - Added todo comments to remove certain test blocks after removal of `TypedStructuredSelectorCreator`.
    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    9b4b7ac View commit details
    Browse the repository at this point in the history

  3. Remove TypedStructuredSelectorCreator from README

    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    73e45f7 View commit details
    Browse the repository at this point in the history

  4. Remove createStructuredAppSelector.ts from examples

    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    140f38f View commit details
    Browse the repository at this point in the history

  5. Remove TypedStructuredSelectorCreator from docs

    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    025c1a4 View commit details
    Browse the repository at this point in the history

  6. Change version to 5.0.2 to workaround CI issue

    @aryaemami59
    aryaemami59 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    1368970 View commit details
    Browse the repository at this point in the history