Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resultEqualityCheck behavior in weakMapMemoize #699

Merged

Commits on Feb 11, 2024

  1. Configuration menu
    Copy the full SHA
    3fb8c98 View commit details
    Browse the repository at this point in the history
  2. Fix resultEqualityCheck behavior in weakMapMemoize

      - Previously `resultEqualityCheck` would be called with empty objects as arguments due to how `inputStabilityCheck` works. This update Fixes `resultEqualityCheck` in `weakMapMemoize` so that when input selectors are stable it does not get called on the first run of the output selector.
    aryaemami59 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    4228bc1 View commit details
    Browse the repository at this point in the history
  3. Add tests for weakMapMemoize and resultEqualityCheck integration

      - Added runtime unit tests to verify that:
        - `resultEqualityCheck` works correctly when set to `shallowEqual`.
        - `resultEqualityCheck` is not called on the first output selector call.
        - `weakMapMemoize` with `resultEqualityCheck` set to `referenceEqualityCheck` works the same as `weakMapMemoize` without `resultEqualityCheck`.
    aryaemami59 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    acbf08b View commit details
    Browse the repository at this point in the history
  4. Add tests for lruMemoize and resultEqualityCheck integration

      - Added runtime unit tests to verify that:
        - `resultEqualityCheck` works correctly when set to `shallowEqual`.
        - `resultEqualityCheck` is not called on the first output selector call.
        - `lruMemoize` with `resultEqualityCheck` set to `referenceEqualityCheck` works the same as `lruMemoize` without `resultEqualityCheck`.
    aryaemami59 committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c46f8bf View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a2d74b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a15de48 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    197cba9 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'master' of https://github.com/reduxjs/reselect into fix…

    …-weakMapMemoize-resultEqualityCheck
    aryaemami59 committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    cc884cc View commit details
    Browse the repository at this point in the history