Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yarn 4 #705

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Upgrade to Yarn 4 #705

merged 8 commits into from
Mar 11, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Bumps Node versions in CI to 20
  • Upgrades package manager to Yarn 4

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for reselect-docs canceled.

Name Link
🔨 Latest commit 68c3c84
🔍 Latest deploy log https://app.netlify.com/sites/reselect-docs/deploys/65eb6d74b8944b0008cbf9a4

Copy link

codesandbox-ci bot commented Feb 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@aryaemami59 aryaemami59 marked this pull request as ready for review February 21, 2024 20:23
@timdorr
Copy link
Member

timdorr commented Mar 11, 2024

Thanks!

@timdorr timdorr merged commit 9639566 into reduxjs:master Mar 11, 2024
23 checks passed
@aryaemami59 aryaemami59 deleted the upgrade-to-yarn-4 branch March 11, 2024 18:46
descope bot referenced this pull request in descope/descope-js Jun 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [reselect](https://togithub.com/reduxjs/reselect) | dependencies |
patch | [`5.1.0` ->
`5.1.1`](https://renovatebot.com/diffs/npm/reselect/5.1.0/5.1.1) |

---

### Release Notes

<details>
<summary>reduxjs/reselect (reselect)</summary>

###
[`v5.1.1`](https://togithub.com/reduxjs/reselect/releases/tag/v5.1.1)

[Compare
Source](https://togithub.com/reduxjs/reselect/compare/v5.1.0...v5.1.1)

This **patch release** fixes behavior of `resultEqualityCheck` in
`weakMapMemoize`, fixes the case of `lruMemoize` being given a `maxSize`
less than 1, and tweaks the internal implementation of `lruMemoize`.
(We've also updated our general build tooling.)

##### Changelog

##### Bug fixes

Previously, providing the `resultEqualityCheck` option to
`weakMapMemoize` resulted in it being called with empty objects as part
of the initialization / dev check process. That could be an issue if
your comparison function expected different values. We've updated the
logic to avoid that, as well as improving a couple other perf aspects.

Previously, passing a `maxSize` < 1 to `lruMemoize` would result in it
creating a larger cache. That's now fixed.

`lruMemoize` now uses a symbol for its `NOT_FOUND` value instead of a
string.

##### What's Changed

- Ensure `lruMemoize` correctly memoizes when `maxSize` is set to a
number less than 1 by
[@&#8203;aryaemami59](https://togithub.com/aryaemami59) in
[https://github.com/reduxjs/reselect/pull/698](https://togithub.com/reduxjs/reselect/pull/698)
- Fix `resultEqualityCheck` behavior in `weakMapMemoize` by
[@&#8203;aryaemami59](https://togithub.com/aryaemami59) in
[https://github.com/reduxjs/reselect/pull/699](https://togithub.com/reduxjs/reselect/pull/699)
- Update TypeScript to 5.4 by
[@&#8203;aryaemami59](https://togithub.com/aryaemami59) in
[https://github.com/reduxjs/reselect/pull/708](https://togithub.com/reduxjs/reselect/pull/708)
- Upgrade to Yarn 4 by
[@&#8203;aryaemami59](https://togithub.com/aryaemami59) in
[https://github.com/reduxjs/reselect/pull/705](https://togithub.com/reduxjs/reselect/pull/705)
- Fix: use unique value for NOT_FOUND by
[@&#8203;romgrk](https://togithub.com/romgrk) in
[https://github.com/reduxjs/reselect/pull/709](https://togithub.com/reduxjs/reselect/pull/709)

**Full Changelog**:
reduxjs/reselect@v5.1.0...v5.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
aryaemami59 pushed a commit to aryaemami59/reselect that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants