Skip to content

Commit

Permalink
Merge pull request godotengine#86576 from bikemurt/no-concave-warnings
Browse files Browse the repository at this point in the history
Add warning for using concave shape on CharacterBody3D
  • Loading branch information
akien-mga committed Jan 4, 2024
2 parents 8a716e3 + 6838fe3 commit f4059d0
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion scene/3d/collision_shape_3d.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "scene/resources/concave_polygon_shape_3d.h"
#include "scene/resources/convex_polygon_shape_3d.h"
#include "scene/resources/world_boundary_shape_3d.h"
#include "vehicle_body_3d.h"

void CollisionShape3D::make_convex_from_siblings() {
Node *p = get_parent();
Expand Down Expand Up @@ -130,13 +131,24 @@ PackedStringArray CollisionShape3D::get_configuration_warnings() const {
}

if (shape.is_valid() && Object::cast_to<RigidBody3D>(col_object)) {
String body_type = "RigidBody3D";
if (Object::cast_to<VehicleBody3D>(col_object)) {
body_type = "VehicleBody3D";
}

if (Object::cast_to<ConcavePolygonShape3D>(*shape)) {
warnings.push_back(RTR("ConcavePolygonShape3D doesn't support RigidBody3D in another mode than static."));
warnings.push_back(vformat(RTR("When used for collision, ConcavePolygonShape3D is intended to work with static CollisionObject3D nodes like StaticBody3D.\nIt will likely not behave well for %ss (except when frozen and freeze_mode set to FREEZE_MODE_STATIC)."), body_type));
} else if (Object::cast_to<WorldBoundaryShape3D>(*shape)) {
warnings.push_back(RTR("WorldBoundaryShape3D doesn't support RigidBody3D in another mode than static."));
}
}

if (shape.is_valid() && Object::cast_to<CharacterBody3D>(col_object)) {
if (Object::cast_to<ConcavePolygonShape3D>(*shape)) {
warnings.push_back(RTR("When used for collision, ConcavePolygonShape3D is intended to work with static CollisionObject3D nodes like StaticBody3D.\nIt will likely not behave well for CharacterBody3Ds."));
}
}

Vector3 scale = get_transform().get_basis().get_scale();
if (!(Math::is_zero_approx(scale.x - scale.y) && Math::is_zero_approx(scale.y - scale.z))) {
warnings.push_back(RTR("A non-uniformly scaled CollisionShape3D node will probably not function as expected.\nPlease make its scale uniform (i.e. the same on all axes), and change the size of its shape resource instead."));
Expand Down

0 comments on commit f4059d0

Please sign in to comment.