Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ts-to-js #73

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

rushabhhere
Copy link

Converted the code in #71 to js using rw ts-to-js. The purpose of this PR is to check the diff between the generated js and the code in this repository.

@cannikin
Copy link
Member

Just saw this! Looks like it's the result of our discussion over in #71?

@Tobbe how does this look? I noticed some weirdness likes the @redwoodjs/core version going from 2.2.0 down to 2.0.0? This also doesn't have the new separate form helper file that we're going to generate going forward...

@Tobbe
Copy link
Member

Tobbe commented Oct 2, 2022

@cannikin I still believe in the general idea here, but I agree some of the changes look weird. I don't think that's because of ts-to-js though. I think we should bring #71 up to date, and then regenerate this PR to see what the changes look like

@rushabhhere
Copy link
Author

@Tobbe @cannikin I have updated this PR with respect to my recent additions to #71, please check.

@cannikin
Copy link
Member

cannikin commented Nov 7, 2022

@Tobbe I assume that the merge of decoupled auth is going to affect this PR? In App.js everything is still imported from @redwoodjs/api, and that's just the first thing I checked. There's also changes to .vscode/launch.json which was maybe overridden by @rushabhhere own dev environment?

I don't know that I'm even qualified to approve this: too much TS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants