Skip to content

Commit

Permalink
Firebase - fix for 8.3.x. (#2134)
Browse files Browse the repository at this point in the history
* Firebase - fix for 8.3.x.

* Snapshot update.

* Lint fix.

Co-authored-by: Thomas Seillan <smokinglaslo@gmail.com>
  • Loading branch information
noire-munich and noire-munich authored Apr 3, 2021
1 parent 4642797 commit 1ebf848
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default App

exports[`Should add config lines to App.{js,tsx} Matches Firebase Snapshot 1`] = `
"import { AuthProvider } from '@redwoodjs/auth'
import * as firebase from 'firebase/app'
import firebase from 'firebase/app'
import 'firebase/auth'
import { FatalErrorBoundary } from '@redwoodjs/web'
import { RedwoodApolloProvider } from '@redwoodjs/web/apollo'
Expand All @@ -52,7 +52,6 @@ import './index.css'
const firebaseClientConfig = {
apiKey: process.env.FIREBASE_API_KEY,
authDomain: process.env.FIREBASE_AUTH_DOMAIN,
databaseURL: process.env.FIREBASE_DATABASE_URL,
projectId: process.env.FIREBASE_PROJECT_ID,
storageBucket: process.env.FIREBASE_STORAGE_BUCKET,
messagingSenderId: process.env.FIREBASE_MESSAGING_SENDER_ID,
Expand Down
6 changes: 1 addition & 5 deletions packages/cli/src/commands/setup/auth/providers/firebase.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
// the lines that need to be added to App.{js,tsx}
export const config = {
imports: [
`import * as firebase from 'firebase/app'`,
`import 'firebase/auth'`,
],
imports: [`import firebase from 'firebase/app'`, `import 'firebase/auth'`],
init: `const firebaseClientConfig = {
apiKey: process.env.FIREBASE_API_KEY,
authDomain: process.env.FIREBASE_AUTH_DOMAIN,
databaseURL: process.env.FIREBASE_DATABASE_URL,
projectId: process.env.FIREBASE_PROJECT_ID,
storageBucket: process.env.FIREBASE_STORAGE_BUCKET,
messagingSenderId: process.env.FIREBASE_MESSAGING_SENDER_ID,
Expand Down

0 comments on commit 1ebf848

Please sign in to comment.