[Tech debt]: Re-enable telemetry for windows

[dac09]

What's not working?

We are disabling telemetry on Windows in #5899 - due to the terminal windows opening when using the CLI.

We need to renable telemetry, once we can workout a way of preventing the terminal windows spawining.

Related Issues

• Weird Issue with Windows 11 cmd #5757
• Telemetry opens an onslaught of command prompts when ran on Windows #5728

[Gresliebear]

Node added a windowHide option

nodejs/node#15380

child_process.spawn(cmd, args, { shell: true, detached: true, windowsHide: true })

so some how in dry_run.ts we need to pass 'windowsHide:true' opts on spawnCancellable

However I have read that its "On Windows, however, .bat and .cmd files are not executable on their own without a terminal" from the Node docs

I gave it a shot but it didnt work

[jtoar]

@Gresliebear thanks for looking into this. We've tried windowsHide (#5734), but it doesn't seem to work with detached processes: nodejs/node#21825.

[Gresliebear]

@Gresliebear thanks for looking into this. We've tried windowsHide (#5734), but it doesn't seem to work with detached processes: nodejs/node#21825.

Good Lord it looks like it has not been fixed since 2018

[dac09]

Good Lord it looks like it has not been fixed since 2018

Haha hears windows XP shutdown sound.

I think what we'll need to do is have a simple reproduction (without our CLI) - when I tried this, I couldn't get the windows to spawn... so I'm confused exactly what the problem is. Maybe it happens when you spawn in certain situations (e.g. through execa/yargs/something we use).