fix: enable windowsHide for Windows OSes
#5734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for redwoodjs-docs canceled.
|
dac09
approved these changes
Jun 20, 2022
|
I'm going to get this into canary and test on Windows @jtoar! |
|
@dac09 great! Meant to give you a heads up about the assignment but I think you said you could test it out right? Just forgot to assign last week. Also there's a user who tried modifying node_modules with the change to no avail, but still holding out hope that the fix is something simple like this: #5728 (comment) |
|
Unfortunately the fix doesn't quite work @jtoar. But I think you're on the right track... I didn't want to put it in the original issue, but the way I know its telemetry is because disabling telemetry with the env var means the problem goes away. |
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Jun 20, 2022
…ctmode-gen * 'main' of github.com:redwoodjs/redwood: (24 commits) fix: enable `windowsHide` for Windows OSes (redwoodjs#5734) Simplify check (redwoodjs#5746) Version docs to 2.0 Update all contributors v2.0.0 fix(deps): update graphqlcodegenerator monorepo (redwoodjs#5772) fix(deps): update storybook monorepo to v6.5.9 (redwoodjs#5770) fix(deps): update dependency core-js to v3.23.1 (redwoodjs#5771) fix(deps): update dependency @apollo/client to v3.6.8 (redwoodjs#5769) Correct a few spelling mistakes (redwoodjs#5747) docs: yet another set of single byte typo squashing (redwoodjs#5749) docs: GraphQL Yoga's playground, not Apollo Server's (redwoodjs#5741) docs(graphql): replaced outdated mentions to Apollo Server (redwoodjs#5768) Update routing-params.md (redwoodjs#5706) fixing typo (redwoodjs#5699) fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704) Lint fix some template files (redwoodjs#5766) fix: RedwoodLogger -- Mask errors, but include stack trace in formatter (redwoodjs#5704) Lint fix some template files (redwoodjs#5766) docs: adding precisions and fixes to contributing (redwoodjs#5760) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe closes #5728. See https://nodejs.org/dist/latest-v16.x/docs/api/child_process.html#child_processspawncommand-args-options.